Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed docker_ variables to docker__ #15

Merged
merged 4 commits into from
Jul 20, 2016

Conversation

tallandtree
Copy link
Contributor

Docker_ variables are moved into their own namespace.
Correct variable type resolution by Ansible is ensured by changing
".changed" to "|changed".

Docker_ variables are moved into their own namespace.
Correct variable type resolution by Ansible is ensured by changing
".changed" to "|changed".


# .. envvar:: docker_fixed_cirt
# .. envvar:: docker__fixed_cirt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be docker__fixed_cidr.

Copy link
Contributor Author

@tallandtree tallandtree Jul 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, it is docker__fixed_cirt in my local repo. Will have a look. Ok, see what you mean now. It should be cidr. I'll fix that too and check the documentation as well.

@ypid
Copy link
Member

ypid commented Jul 20, 2016

@tallandtree For bonus points check Migration/upgrade notes 😉

@@ -1,6 +1,20 @@
Changelog
=========

**debops.docker**

`debops.docker master`_ - unreleased
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can change this to plain debops.docker master - unreleased for now, Changelog will be updated later.

Else the generation of the docs will fail. Changelog will be updated
later.
@drybjed drybjed merged commit c2e6d86 into debops:master Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants